This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): improve vite-node hmr
#6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
DamianGlowala
suggested changes
Aug 4, 2022
Co-authored-by: Damian GΕowala <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian GΕowala <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian GΕowala <48835293+DamianGlowala@users.noreply.github.com>
|
This is nice solution <3 Locally trying on an external project (MacOS), Server HMR seems perfectly working but only we are invalidating some unnecessary chunks. Which could be probably improved later.
|
pi0
approved these changes
Aug 4, 2022
pi0
changed the title
vite-node HMRvite-node hmr
This was referenced Aug 4, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
close nuxt/nuxt#14469
β Type of change
π Description
This PR implemented the full HMR support of vite-node as mentioned in #6154 (comment)
Re nuxt/nuxt#14469, the bug is caused because in the release build,
entry.mjsis laying undernode_moduleswhich bypasses the cache clear up due to #6153π Checklist