Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): add viteServerDynamicImports as experimental flag #6433

Merged
merged 8 commits into from
Aug 8, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 8, 2022

πŸ”— Linked issue

nuxt/nuxt#14525

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR disables change introduced in #5506 (rc.5 and rc.6) and move it behind experimental.viteServerDynamicImports flag until we can identify related issues. To enable:

import { defineNuxtConfig } from 'nuxt'

export default defineNuxtConfig({
  experimental: {
    viteServerDynamicImports: true
  }
})

Todo:

  • Test webpack behavior (works fine with dynamic chunks! seems vite-only issue therefore updating exeprimental flag)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 8, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 827e07a
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f10ed12ed453000884d809

@pi0 pi0 marked this pull request as ready for review August 8, 2022 13:15
@pi0 pi0 changed the title fix(nuxt): add serverDynamicImports as experimental flag fix(nuxt): add viteServerDynamicImports as experimental flag Aug 8, 2022
@pi0 pi0 changed the title fix(nuxt): add viteServerDynamicImports as experimental flag fix(nuxt): add viteServerDynamicImports as experimental flag Aug 8, 2022
@pi0 pi0 merged commit ee36ddf into main Aug 8, 2022
@pi0 pi0 deleted the fix/experimental-dynamic branch August 8, 2022 13:25
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants