This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
refactor(nuxt)!: remove null handling for titleTemplate
#6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
|
Have you checked notes in #6296 (comment)? I belive it was to avoid a breaking change for null handling |
|
Yes, I spotted that. I think an acceptable change for RC7 if you agree, but we'll need to mention in release notes. |
|
Do you mind to update PR as breaking change for migration guide? |
danielroe
changed the title
pi0
approved these changes
Aug 10, 2022
pi0
changed the title
null handling for titleTemplate
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
follow on from #6296
❓ Type of change
📚 Description
It seems we have a little leftover
titleTemplatehandling. I think we don't need this - was there a reason we left it in?👉 Migration
If you were previously using
titleTemplate: nullyou should update this totitleTemplate: ''.📝 Checklist