Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite, nuxt): resolve relative to srcDir rather than rootDir #6546

Merged
merged 4 commits into from
Aug 12, 2022
Merged

fix(vite, nuxt): resolve relative to srcDir rather than rootDir #6546

merged 4 commits into from
Aug 12, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With a custom srcDir, various things were not working, including scanning of new components.

This also makes a couple of changes to vite-node, to match the non-vite node implementation where root is set to srcDir and not rootDir but would value @antfu's verdict on these.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite labels Aug 12, 2022
@danielroe danielroe requested review from pi0 and antfu August 12, 2022 08:49
@danielroe danielroe self-assigned this Aug 12, 2022
@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 1b32c94
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f618d44c27700008a48b0a

danielroe and others added 2 commits August 12, 2022 09:58
@danielroe @antfu
Update packages/vite/src/vite-node.ts
e5edbe9 
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@danielroe
fix: use srcDir
b3c8f0e
@pi0 pi0 changed the title fix(nuxt, vite): resolve relative to srcDir rather than rootDir fix(vite): resolve relative to srcDir rather than rootDir Aug 12, 2022
@pi0 pi0 changed the title fix(vite): resolve relative to srcDir rather than rootDir fix(vite, nuxt): resolve relative to srcDir rather than rootDir Aug 12, 2022
@pi0 pi0 merged commit 70b024f into main Aug 12, 2022
@pi0 pi0 deleted the fix/srcdir-fixes branch August 12, 2022 09:11
@pi0 pi0 mentioned this pull request Aug 12, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

@antfu antfu antfu left review comments

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @pi0 @antfu