Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor: enable strict type checking everywhere #6943

Merged
merged 9 commits into from
Aug 26, 2022
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 25, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is the final PR to enable TS strictness, by enabling strict at top-level tsconfig.json and removing all the tsconfig.json in sub packages.

Blocked by unjs/untyped#45

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 25, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 088e529
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6308e0be23258b000bd6d378
😎 Deploy Preview https://deploy-preview-6943--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Member

pi0 commented Aug 26, 2022

Released unjs/untyped#45 in 0.4.6. Update on main works but seems when we add type assertions, a regression happened to the loader. Still investigating to see what's going on. But two things we need to solve:

  • Regression to the loader
  • Probably a defineSchemaObject from untyped to remove the need for manual <InputObject> for $resolve typeing.

@pi0
Copy link
Member

pi0 commented Aug 26, 2022

Schema is fine now. I will move new type to untyped and release in parallel. We have 41 new appear issues :D

image

@antfu antfu marked this pull request as ready for review August 26, 2022 15:03
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@pi0 pi0 changed the title chore: improve type strictness refactor: enable strict type checking everywhere Aug 26, 2022
@pi0 pi0 merged commit 9db2229 into main Aug 26, 2022
@pi0 pi0 deleted the chore/ts-strict-take-4 branch August 26, 2022 15:47
@pi0 pi0 mentioned this pull request Sep 1, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants