Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt): add default slot to <NuxtLoadingIndicator> #7128

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

daniil4udo
Copy link
Contributor

@daniil4udo daniil4udo commented Sep 1, 2022

❓ Type of change

Add slot to the NuxtLoadingIndicator in case user want to add additional element (like spinner)

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 1, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit f7d9354
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63432a2788f82b000842645a
😎 Deploy Preview https://deploy-preview-7128--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daniil4udo daniil4udo force-pushed the feature/nuxt-loading-indicator-slot branch 3 times, most recently from ae4f41a to 4660e04 Compare September 5, 2022 07:54
@daniil4udo daniil4udo force-pushed the feature/nuxt-loading-indicator-slot branch 2 times, most recently from 038332c to be160f2 Compare September 13, 2022 20:08
@daniil4udo daniil4udo force-pushed the feature/nuxt-loading-indicator-slot branch from be160f2 to f43233e Compare September 14, 2022 08:31
@pi0 pi0 force-pushed the main branch 3 times, most recently from 247e18b to c98e5c7 Compare September 14, 2022 10:41
@daniil4udo daniil4udo force-pushed the feature/nuxt-loading-indicator-slot branch 2 times, most recently from 3550c40 to 3eb8a58 Compare September 21, 2022 09:20
Copy link
Contributor Author

@daniil4udo daniil4udo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniil4udo daniil4udo force-pushed the feature/nuxt-loading-indicator-slot branch from 3eb8a58 to d3b9226 Compare September 23, 2022 19:57
@danielroe danielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Oct 9, 2022
@danielroe danielroe changed the title feat(nuxt): add default slot to the NuxtLoadingIndicator feat(nuxt): add default slot to <NuxtLoadingIndicator> Oct 10, 2022
@danielroe danielroe merged commit 75f4a54 into nuxt:main Oct 10, 2022
@danielroe danielroe mentioned this pull request Oct 11, 2022
@daniil4udo daniil4udo deleted the feature/nuxt-loading-indicator-slot branch November 21, 2022 09:59
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants