Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

perf(nuxt): import defineNuxtConfig from nuxt/config #7485

Merged
merged 3 commits into from
Sep 14, 2022
Merged

perf(nuxt): import defineNuxtConfig from nuxt/config #7485

merged 3 commits into from
Sep 14, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 13, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#14821

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR introduces new nuxt/config subpath export with CJS+MJS build to avoid jiti extra transformations.

Also using jiti aliases, nuxt is aliases to nuxt/config within nuxt.config file. This way we transparently introduce this enhancement to all nuxt 3 users. defineNuxtConfig from nuxt is deprecated. Pending docs/examples update to after release and try. Alias seemed little bit hacky to do and causing potential breaking changes.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 13, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 5e77dc2
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6320eccb71be9100080bc278

@pi0 pi0 changed the title pef(nuxt, kit): import defineNuxtConfig from nuxt/config pef(nuxt): import defineNuxtConfig from nuxt/config Sep 13, 2022
@pi0 pi0 changed the title pef(nuxt): import defineNuxtConfig from nuxt/config perf(nuxt): import defineNuxtConfig from nuxt/config Sep 13, 2022
@pi0 pi0 merged commit 3a60bf6 into main Sep 14, 2022
@pi0 pi0 deleted the perf/config2 branch September 14, 2022 10:37
Copy link
Member

atinux commented Sep 14, 2022

Shall we open an issue to keep track of updating it for documentation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt is transpiled from nuxt.config
3 participants