fix(vite): include importer in vite-node error stack
#7607
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
| return new ViteNodeRunner({ | ||
| root: viteNodeOptions.root, // Equals to Nuxt `srcDir` | ||
| base: viteNodeOptions.base, | ||
| resolveId (id, importer) { _importers.set(id, importer) }, | ||
| async fetchModule (id) { |
There was a problem hiding this comment.
@antfu is it possible for vite-node to directly give importer to the fetchModule? It could be useful to format errors better.
There was a problem hiding this comment.
The problem is that a module could be imported by multiple importers and vite-node caches them to reuse the existing one. That means if we could have the importer it could only be the first one hit the module and can be changed in different requests.
There was a problem hiding this comment.
I see. Indeed makes sense. But how do you think about this solution for Nuxt to hint about error? I suppose first importer triggers the error this way.
There was a problem hiding this comment.
Maybe we could update the logging message to be something like (first imported by x) to keep it accurate?
There was a problem hiding this comment.
having imported by is also accurate (it could be, also imported by y but as result of being imported by x is now being failed). Similar to other stack traces if a util is used by two functions, first function calling it shows in stack trace.
There was a problem hiding this comment.
I will see what I can do on the vite-node side
pi0
changed the title
vite-node error stack
🔗 Linked issue
Ref nuxt/nuxt#14909
❓ Type of change
📚 Description
This PR tries to include (last) importer in stack traces of vite-node formatted errors.
📝 Checklist