This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): router defaults overwrite custom options always #8334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Router default options were introduced in ba3a118. That's great! But now, custom implementations (via
app/router.options.(js|ts)
won't have an effect. The default options stay at the top of all router option layers.The source of the error seems to be:
framework/packages/nuxt/src/pages/module.ts
Line 148 in ba3a118
unshift
adds the default to the beginning, but the router options arereverse
d anyway later:framework/packages/nuxt/src/pages/module.ts
Line 159 in ba3a118
π Checklist