Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: change required node version to be above 16.11 #8408

Merged
merged 1 commit into from
Oct 24, 2022
Merged

docs: change required node version to be above 16.11 #8408

merged 1 commit into from
Oct 24, 2022

Conversation

zecka
Copy link
Contributor

@zecka zecka commented Oct 22, 2022

🔗 Linked issue

nuxt/nuxt#15231
nuxt/nuxt#15203

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Nuxt 3 seems not work on node versions bellow 16. So the documentation need to be updated

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Oct 22, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 22, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit d1ef18f
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/635396a0d330de0008acfbee
😎 Deploy Preview https://deploy-preview-8408--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux atinux requested a review from danielroe October 22, 2022 08:27
@danielroe
Copy link
Member

danielroe commented Oct 22, 2022 •
edited
Loading

This has already been resolved and is a regression only in nuxi@rc12 (in the prepare command only, iirc). The fix has been linked in the issue you raised: #8299

It might be appropriate to add a (temporary) note but we certainly don't want to drop node 14 support because of a bug that has been resolved.

@zecka
Copy link
Contributor Author

zecka commented Oct 22, 2022

@danielroe understood. So we can close this PR.

@zecka zecka closed this Oct 22, 2022
@danielroe
Copy link
Member

(Or if you thought it helpful to add a temporary note with a link, I would also be up for that.)

Just to be clear, I do really appreciate your spotting the issue and raising the PR 😊

@pi0 pi0 reopened this Oct 24, 2022
@pi0
Copy link
Member

pi0 commented Oct 24, 2022

Reopening this makes sense we reduce documentation endorsement for 14 as per notes in nuxt/nuxt#14965.

BTW Syntax usage is fixed and we will probably keep supporting Node.js 14 by best efforts until it's EOL in few months.

@pi0 pi0 changed the title docs: Change required node version docs: change required node version to be above 16.11 Oct 24, 2022
@pi0 pi0 merged commit 708460d into nuxt:main Oct 24, 2022
@HigherOrderLogic HigherOrderLogic mentioned this pull request Jan 19, 2023
Closed
@pi0 pi0 mentioned this pull request Nov 3, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe Awaiting requested review from danielroe

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zecka @danielroe @pi0