You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a breaking change coming with this PR indeed. When navigating on client-side, the initial payload cache won't be used as option is dropped. Later will add actual cache support as mentioned in #3985
As I understand it, that will basically break the payloadExtraction implementation because this will only be used on initial load (which was the case even if payloads were not extracted).
If we merge this without fixing this, I think we should also disable payloadExtraction by default.
Note: now that I think about it, I think we should disable payload extraction by default anyway as I think there's some more refinement/discussion to do, particularly around useData, etc. that we probably can't adequately handle before the stable release.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Race condition issue in #3985 seems to be resolved. Removing initialCache option and only use utility to preserve payload data while hydrating.
BREAKING CHANGE: Payload cache won't be used when doing client-side navigation back to same page and fresh data will be fetched.
π Checklist