Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: change app-config url to avoid naming conflicts with app.vue #9377

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

clemcode
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

app.config and app URLs were conflicting in the directory structure section causing a blank page. Renaming to app-config for URLs.

@clemcode clemcode requested a review from atinux November 28, 2022 12:21
@codesandbox
Copy link

codesandbox bot commented Nov 28, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@pi0
Copy link
Member

pi0 commented Nov 28, 2022

Is it something we might track for content/docus and fix later to support dot in content paths? /cc @farnabaz

@vercel vercel bot temporarily deployed to Preview November 28, 2022 12:35 Inactive
Copy link
Member

atinux commented Nov 28, 2022

I think it has to be directly with content since this theme does not use Docus.

Also, we need to improve the Docs Aside to fix the highlight @clemcode (but in another release of the website-theme)

CleanShot 2022-11-28 at 13.45.50@2x.png

Copy link
Member

atinux commented Nov 28, 2022

Merging since it fixes a broken page for now.

@pi0 pi0 merged commit 65f3b3a into main Nov 28, 2022
@pi0 pi0 deleted the docs/fix/naming-conflicts branch November 28, 2022 12:47
@TheAlexLichter
Copy link
Member

Please do not forget to set up redirects, even if temporary!

Copy link
Member

atinux commented Nov 28, 2022

Was going to push it but done directly on main: 66efcd5

Thanks @manniL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants