This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): avoid injecting url helpers into globalThis
#9627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
|
|
danielroe
changed the title
globalThisglobalThis
|
Although this will heal the issues similar to nuxt/nuxt#14372, both server and client instances are supposed to run in an isolated environment. I'm okay with such change since also helps with vercel-edge but I'm afraid it won't solve the multi-instance issue. Other things including hookable core depend on unique globalThis instance and it is shared. |
pi0
reviewed
Dec 12, 2022
| // @ts-ignore | ||
| globalThis.__buildAssetsURL = buildAssetsURL | ||
| // @ts-ignore | ||
| globalThis.__publicAssetsURL = publicAssetsURL |
There was a problem hiding this comment.
I think we can keep injecting to globalThis as well
packages/vite/src/server.ts
Outdated
| @@ -24,11 +24,11 @@ export async function buildServer (ctx: ViteBuildContext) { | |||
| return { relative: true } | |||
| } | |||
| if (type === 'public') { | |||
| return { runtime: `globalThis.__publicAssetsURL(${JSON.stringify(filename)})` } | |||
| return { runtime: `__publicAssetsURL(${JSON.stringify(filename)})` } | |||
There was a problem hiding this comment.
Then here we can conditionally render either with globalThis or without based on auto imports being enabled.
danielroe
changed the title
globalThisglobalThis
Merged
danielroe
added a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14372
❓ Type of change
📚 Description
On server-side, rather than declaring
__buildAssetsURLand__publicAssetsURLonglobalThis, this PR relies on nitro auto-imports to ensure they are injected where needed in the server app.Note: We would need to ensure that the nitro auto-imports functionality cannot be turned off if we are relying on it in this context. See also nitrojs/nitro#742.
📝 Checklist