Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): remove absolute paths from routes objects #9655

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15637

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Absolute file paths were being embedded in the build by the pages integration in two places - in the meta variable as well as in the .file attribute (which is not used by vue-router as far as I can tell). We can safely relativise the former and remove the latter.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Dec 11, 2022
@danielroe danielroe self-assigned this Dec 11, 2022
@codesandbox
Copy link

codesandbox bot commented Dec 11, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title fix(nuxt): use relative path for generate meta name fix(nuxt): remove absolute paths from routes objects Dec 11, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (resolving from srcDir to be fixed later together with other places)

@pi0 pi0 merged commit 23307cd into main Dec 12, 2022
@pi0 pi0 deleted the fix/relative-component-name branch December 12, 2022 12:25
@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt use absolute path when build and generate
3 participants