Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve cloudflare provider page #1601

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

ymansurozer
Copy link
Contributor

πŸ”— Linked issue

Resolves #1546 and #805.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The documentation for Cloudflare is missing an important step, which is to enable image transformations for the deployment URL at Cloudflare dashboard. Otherwise, the module does not work and it causes a lot of confusion for initial setup. This PR aims to clarify this with a warning callout.

@danielroe danielroe merged commit dcc4b4c into nuxt:main Nov 18, 2024
2 checks passed
@danielroe
Copy link
Member

Thank you!

@github-actions github-actions bot mentioned this pull request Nov 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 62.98%. Comparing base (e7e670d) to head (8aa5eaa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   62.98%   62.98%           
=======================================
  Files          79       79           
  Lines        3534     3534           
  Branches      406      407    +1     
=======================================
  Hits         2226     2226           
  Misses       1279     1279           
  Partials       29       29           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hi, I am trying to get NuxtImg going with CloudFlare images. https://image.nuxt.com/providers/cloudflare
3 participants