feat(rspack): dev & build #20067
Closed
feat(rspack): dev & build #20067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
underfin
commented
Apr 4, 2023
underfin
commented
Apr 4, 2023
underfin
commented
Apr 4, 2023
| const cssLoaders = createCssLoadersRule(ctx, options.webpack.loaders.css) | ||
| const cssModuleLoaders = createCssLoadersRule(ctx, options.webpack.loaders.cssModules) | ||
| // const cssLoaders = createCssLoadersRule(ctx, options.webpack.loaders.css) | ||
| // const cssModuleLoaders = createCssLoadersRule(ctx, options.webpack.loaders.cssModules) |
There was a problem hiding this comment.
Rspack support MiniCssExtractPlugin + CssMinimizerPlugin + CssModules by default.
underfin
commented
Apr 4, 2023
underfin
commented
Apr 4, 2023
| @@ -36,6 +37,7 @@ export async function bundle (nuxt: Nuxt) { | |||
| return getRspackConfig(ctx) | |||
| }) | |||
|
|
|||
| // @ts-ignore | |||
| await nuxt.callHook('rspack:config', webpackConfigs) | |||
There was a problem hiding this comment.
Here missing some hook key for rspack.
There was a problem hiding this comment.
If rspack aspires to drop-in compatibility with webpack, I think we could consider renaming these hooks back to the webpack:* prefix.
underfin
commented
Apr 4, 2023
| @@ -64,7 +66,7 @@ export async function bundle (nuxt: Nuxt) { | |||
|
|
|||
| // In dev, write files in memory FS | |||
| if (nuxt.options.dev) { | |||
| compiler.outputFileSystem = mfs as unknown as OutputFileSystem | |||
| compiler.outputFileSystem = mfs as any /* as OutputFileSystem */ | |||
There was a problem hiding this comment.
I'm not sure it need at rspack, getRspackMemoryAssets should work for dev server visit resource. Maybe it used for online editor?
underfin
commented
Apr 4, 2023
packages/rspack/src/rspack.ts
Outdated
|
|
||
| // Register devMiddleware on server | ||
| // @ts-ignore |
There was a problem hiding this comment.
The webpackHotMiddleware is compatiable with rspack, only type issue...
|
Any update on this? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist