Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mockImplementation() call #29669

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

enkot
Copy link
Contributor

@enkot enkot commented Oct 24, 2024

🔗 Linked issue

resolves nuxt/test-utils#864

📚 Description

Function inside mockImplementation() will be reset by resetAllMocks()/restoreAllMocks() and is redundant.

Beginners may be confused as to why the default mock function does not work 🤯

@enkot enkot requested a review from danielroe as a code owner October 24, 2024 14:07
Copy link

stackblitz bot commented Oct 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@danielroe danielroe merged commit 20bcb8d into nuxt:main Oct 24, 2024
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
danielroe pushed a commit that referenced this pull request Oct 24, 2024
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitest restore mock sets all hoisted mocks to undefined when following documentation
2 participants