-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): zero-downtime pm2 typescript example #4907
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4907 +/- ##
==========================================
- Coverage 91.79% 91.74% -0.05%
==========================================
Files 73 73
Lines 2412 2412
Branches 593 593
==========================================
- Hits 2214 2213 -1
- Misses 180 181 +1
Partials 18 18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR !
I suggested some changes 🙂
Can't wait to be able to have a true zero-downtime PM2 setup 😃
Would it be possible to extend the example to include documentation and/or a command to have zero-downtime while also having to (re)build Nuxt? It seems to me that currently this example is only about zero-downtime while restarting nuxt server but (again it seems, maybe nuxt-ts works differently on start) to skip the build phase? |
All depends on your need. |
- some fixes + update readme
- remove process.send from core - update example
@dschewchenko I changed the title as it's not changing anymore Nuxt core but using the Thanks for your time ! And thank you @pimlie for the Will test it on my server later this day and approve the PR. FYI there is a pending PR regarding big perf enhancement using |
Types of changes
New example
Description
Addprocess.send('ready')
when nuxt server is listeningResolves #3078
I added simple example with pm2 configuration and use listen hook in nuxt.config for sending
ready
event to pm2Checklist: