Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): avoid css chunk error #5173

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Conversation

sskyu
Copy link

@sskyu sskyu commented Mar 7, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Chunk error has recurrence in the current nuxt version.
The error object at that time is as follows.

{
  "statusCode": 500,
  "message": "Loading CSS chunk 25 failed.\n(/_nuxt/pages/foo/911a4b9a11aff85b804a.css)"
}

So, I added code for consider css chunk error.

Resolves: #3389
Ref: #3940

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #5173 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5173      +/-   ##
=========================================
+ Coverage   96.52%   96.6%   +0.08%     
=========================================
  Files          72      72              
  Lines        2447    2447              
  Branches      620     620              
=========================================
+ Hits         2362    2364       +2     
+ Misses         70      68       -2     
  Partials       15      15
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 95.85% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cffd884...30cfde9. Read the comment docs.

@pi0 pi0 requested a review from aldarund March 7, 2019 10:10
@pi0 pi0 merged commit 41028a4 into nuxt:dev Mar 7, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[edge] Deployment of new version breaking site for live users. ( Loading chunk {n} failed error)
5 participants