perf: remove unnecessary dependencies #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 82.76% 83.11% +0.35%
==========================================
Files 19 19
Lines 615 616 +1
Branches 71 74 +3
==========================================
+ Hits 509 512 +3
+ Misses 105 102 -3
- Partials 1 2 +1
☔ View full report in Codecov by Sentry. |
antfu
commented
Sep 30, 2023
| @@ -13,9 +13,9 @@ export interface FilesEvent { | |||
| export const files = <EventFactory<FilesEvent>> async function (context) { | |||
| const { options } = context.nuxt | |||
|
|
|||
| const nuxtIgnore = await pathExists(resolve(options.rootDir, '.nuxtignore')) | |||
There was a problem hiding this comment.
I am not sure if they have difference other than the API style.
According to nodejs/node#39960 (comment), the reason for not having fs/promises/exists is because it's not neccessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 49MB -> 41MB (the main overhead is
@babel/standalonefrom@nuxt/kitit's shared with Nuxt tho).https://pkg-size.dev/@nuxt%2Ftelemetry
nuxt/nuxt#23380