Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-utils): proxy wrapper props #1099

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix(runtime-utils): proxy wrapper props #1099

merged 1 commit into from
Jan 27, 2025

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jan 26, 2025

πŸ”— Linked issue

Fixes: #1064

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When using mountSuspended, wrapper.props returns the props of the wrapped component instead of the specified component.
To address this, proxy wrapper.props so that it returns the props of the MountSuspendedComponent.

@wattanx wattanx marked this pull request as ready for review January 27, 2025 14:03
@wattanx wattanx requested a review from danielroe as a code owner January 27, 2025 14:03
@danielroe danielroe merged commit 3506fc1 into main Jan 27, 2025
4 checks passed
@danielroe danielroe deleted the fix/proxy-props branch January 27, 2025 20:06
@danielroe
Copy link
Member

thank you ❀️

@github-actions github-actions bot mentioned this pull request Jan 26, 2025
@sebbayer
Copy link

thanks for the fix πŸ‘ looking forward to next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapper.props() not working with mountSuspended
3 participants