-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to run e2e tests against existing server #803
Conversation
@danielroe friendly ping. Is there anything a can improve in this PR? |
I love this and would like to get this or something like it merged, but just want to make sure we do it in the best way. Will review soon. |
@tobiasdiez Is the only use-case here avoiding restarting/rebuilding the server when running tests? (ie. if we can solve that issue, do you still think this is a needed feature?) |
My use cases are:
Personally, the first use case is actually more important for me. |
This PR seems ideal for my use-case as well. We build for the nitro preset Being able to do a build separately, running the build via The only issue I encounter is that it cannot seem to fetch the manifest: @danielroe I'd be open to other ways of speeding up/reusing a build, but this PR seems promising other than the manifest error above |
I think we'll go ahead with this approach. Would you be able to add a test? 🙏 |
This is awesome and will be super useful for us. Let me know if the Nuxt docs page needs to be updated and I’m happy to write something up and submit a PR |
@danielroe Thanks for merging. I'll try to add tests when I find the time. @adamdehaven Would be awesome if you could create a PR adding this option to the docs. |
Documents the new 'host' setup property for test-utils end-to-end testing introduced by nuxt/test-utils#803.
PR to add the new |
This is so cool! Thank you so much, I will give it a try asap. |
Allow to pass the url of an already running server to
setup
and use this as the target instead of building and running a new server. This has two use cases:Usage:
(or of course just using a hard-coded url)