Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should downgrade to typescript@~3.5 #98

Closed
kevinmarrec opened this issue Sep 3, 2019 · 0 comments
Closed

Should downgrade to typescript@~3.5 #98

kevinmarrec opened this issue Sep 3, 2019 · 0 comments
Labels
bug Something isn't working build The issue or pull request is related to `build` package dependencies Pull requests that update a dependency file runtime The issue or pull request is related to `runtime` package

Comments

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Sep 3, 2019 •
edited
Loading

Description

Should downgrade from typescript@3.6.2 to typescript@~3.5 for now, cause of broken Vue types around 3.6 (vuejs/vue#10455 ~ microsoft/TypeScript#33164)

Solution

Downgrade TypeScript to 3.5.x for now and pin to patch version only (~3.5 tilde range) to prevent the breaking changes that TypeScript minor versions bring.

Then when the type issues for Vue will be fixed through a 3.6 patch release, switch to pinned patch versions only of 3.6.x (~3.6 tilde range).
@kevinmarrec kevinmarrec added dependencies Pull requests that update a dependency file bug Something isn't working build The issue or pull request is related to `build` package runtime The issue or pull request is related to `runtime` package labels Sep 3, 2019
This was referenced Sep 3, 2019
Merged
Merged
@kevinmarrec kevinmarrec changed the title Should downgrade to typescript@3.5.3 Should downgrade to typescript@~3.5 Sep 3, 2019
@VeeeneX VeeeneX mentioned this issue Sep 12, 2019
Closed
NickBolles pushed a commit to NickBolles/typescript-1 that referenced this issue Oct 25, 2019
@aldarund
Fix linting thrown from default template when enabling prettier optio…
5ecab1c 
…n, container centering when enabling tailwind option (nuxt#98)

* fix default linting errors when enabling prettier option
* fix centering issue for tailwind option, fix vuetify styles for prettier option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build The issue or pull request is related to `build` package dependencies Pull requests that update a dependency file runtime The issue or pull request is related to `runtime` package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinmarrec