Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): accept partial config in ui prop #2235

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix(components): accept partial config in ui prop #2235

merged 2 commits into from
Sep 23, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Sep 22, 2024 •
edited
Loading

🔗 Linked issue

https://github.com/nuxt/nuxt.com/actions/runs/10976089585/job/30476464208 (cc: @atinux)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This moves to use DeepPartial to allow deeply partial ui config.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Sep 22, 2024
@danielroe danielroe marked this pull request as ready for review September 22, 2024 21:27
@benjamincanac benjamincanac changed the title fix: accept partial ui config in component props fix(components): accept partial config in ui prop Sep 23, 2024
@benjamincanac benjamincanac merged commit eecf4f7 into dev Sep 23, 2024
2 checks passed
@benjamincanac benjamincanac deleted the chore/deep-partial branch September 23, 2024 08:55
patrick-hofmann pushed a commit to patrick-hofmann/nuxt-ui that referenced this pull request Oct 3, 2024
@danielroe @patrick-hofmann
fix(components): accept partial config in ui prop (nuxt#2235)
824e2b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @benjamincanac