Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): replace as const with correct type in config #2652

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Nov 15, 2024

Fixes #2636

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@gioboa gioboa changed the title fix: remove const from carousel button config fix: update carousel button config with ButtonColor type Nov 15, 2024
@gioboa gioboa changed the title fix: update carousel button config with ButtonColor type fix: replace as const from configurations with the correct type Nov 15, 2024
@sandros94
Copy link
Collaborator

I'm starting to notice this is actually part of a bigger inconsistency in how components are actually typed. For instance the Divider has its size typed, but not its variant:

import type { divider } from '#ui/ui.config'
export type DividerSize = keyof typeof divider.border.size.horizontal | keyof typeof divider.border.size.vertical

Personally I would merge this to simply fix the related issue, then in a different PR experiment if it is actually possible to fix all typing. Or is it even worth considering v3? @benjamincanac WDYT?

@sandros94 sandros94 added the bug Something isn't working label Nov 16, 2024
@benjamincanac benjamincanac changed the title fix: replace as const from configurations with the correct type fix(components: replace as const with correct type in config Nov 20, 2024
@benjamincanac benjamincanac changed the title fix(components: replace as const with correct type in config fix(components): replace as const with correct type in config Nov 20, 2024
@benjamincanac
Copy link
Member

@sandros94 I think we can just merge that like you said, it's good enough. All of this hassle is already fixed in v3.

@benjamincanac benjamincanac merged commit 51c8b8e into nuxt:dev Nov 20, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @gioboa! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel: arrow color typing in app.config.ts only allows 'black'
3 participants