-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): replace as const
with correct type in config
#2652
Conversation
I'm starting to notice this is actually part of a bigger inconsistency in how components are actually typed. For instance the ui/src/runtime/types/divider.d.ts Lines 1 to 3 in d0e626c
Personally I would merge this to simply fix the related issue, then in a different PR experiment if it is actually possible to fix all typing. Or is it even worth considering |
as const
with correct type in config
as const
with correct type in configas const
with correct type in config
@sandros94 I think we can just merge that like you said, it's good enough. All of this hassle is already fixed in |
Thanks @gioboa! π |
Fixes #2636
π Linked issue
β Type of change
π Description
π Checklist