-
Notifications
You must be signed in to change notification settings - Fork 886
feat: support disabling router integrations #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
commit: |
This might introduce complication with the upcomming |
Indeed, I don't see how we can do this without breaking every component that uses |
Sorry @benjamincanac I don't get how the currently-implemented Inertia integration would circumvent this issue then? |
@innocenzi We've overridden the Link and LinkBase components for Inertia to use InertiaLink and usePage: https://github.com/nuxt/ui/tree/v4/src/runtime/inertia/components |
@benjamincanac Right, but how come we can't just do the same with a generic |
f436d47
to
061dfde
Compare
Would this also fix issues when passing InertiaLink props (https://inertiajs.com/link)? I need to set props (e.g. something like this https://inertiajs.com/links#partial-reloads), but it doesn't seem to be passed to links generated by NuxtUI at the moment? |
@francoism90 no, this PR would not fix that |
π Linked issue
Closes #4233
Related to #4341
β Type of change
π Description
This pull request is an attempt at allowing the use of Nuxt UI in frameworks that don't require
vue-router
. This is the case in Inertia applications (even if Inertia currently has its own exception built in Nuxt UI), in Hybridly applications, in SPAs without routing, etc.I took the same approach as the Inertia override: if the new
router
option is set tofalse
, it will load stubs withoutvue-router
.