fix(types): resolve ambient declaration error in icons type

[vitpetricak]

🔗 Linked issue

Resolves #4959

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

According to typechecking error message, it is not possible to have object in ambient types. This fix resolves it by replacing const icons by defining it as a type.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[pkg-pr-new]

npm i https://pkg.pr.new/@nuxt/ui@4991

commit: 58fa7b6

[sandros94]

Great catch! I knew something was off with that one!

Tho, now that I think of it, this could create more issues (on a type inpout perspective)

EDIT:

yes it would get constrained to a specific icon

[sandros94]

@vitpetricak hope you don't mind if I jumped in with the small 58fa7b6 fix

@benjamincanac this also allow defining your custom icons with type support!

[vitpetricak]

@vitpetricak hope you don't mind if I jumped in with the small 58fa7b6 fix

Not at all, I tried to check if the types would work properly, but for some reason the defineAppConfig types for me were not working. The ui object was typed as any - but I suspected it is error somewhere on my side. The fix you did seems to be correcting that behavior?

So thank you so much for fixing that :) This was blocking us whole last week and I was happy to fix at least the part that blocked us.

[sandros94]

Not at all, I tried to check if the types would work properly, but for some reason the defineAppConfig types for me were not working. The ui object was typed as any - but I suspected it is error somewhere on my side. The fix you did seems to be correcting that behavior?

Yes your local ts server might hang/crash the first time you start the local dev of this library and type stuff as any. Now it works perfectly, while also leaving room for downstream customization

So thank you so much for fixing that :) This was blocking us whole last week and I was happy to fix at least the part that blocked us.

No, thank you.
When you opened that issue I was almost sure, but not completely, that had to be a different problem from the other defineProps issues we have

[benjamincanac]

Nice catch! I believe this was one of the first things I did on v3 😅