Skip to content

fix(Progress): improve status-position when 0 #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2025
Merged

fix(Progress): improve status-position when 0 #4994

merged 5 commits into from
Sep 16, 2025

Conversation

HugoRCD
Copy link
Member

@HugoRCD HugoRCD commented Sep 16, 2025 •
edited
Loading

🔗 Linked issue

Resolves #4993

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

CleanShot.2025-09-16.at.13.07.46.mp4

@github-actions github-actions bot added the v4 #4488 label Sep 16, 2025
@HugoRCD HugoRCD changed the title fix(Progress): status indicator fix(Progress): improve status-position when 0 Sep 16, 2025
@HugoRCD HugoRCD self-assigned this Sep 16, 2025
@HugoRCD HugoRCD marked this pull request as ready for review September 16, 2025 09:02
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 16, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4994

commit: f75c829

benjamincanac
benjamincanac reviewed Sep 16, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the 0% should go out of the container, it should stay on the left right?

@benjamincanac
Copy link
Member

What about always adding a min-w-fit (min-width: fit-content)?

benjamincanac
benjamincanac reviewed Sep 16, 2025
View reviewed changes
@benjamincanac benjamincanac merged commit 0e1e44c into v4 Sep 16, 2025
15 checks passed
@benjamincanac benjamincanac deleted the fix/4993 branch September 16, 2025 14:11
benjamincanac added a commit that referenced this pull request Sep 16, 2025
@HugoRCD @benjamincanac
fix(Progress): improve status-position when 0 (#4994)
5456b8c 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
benjamincanac added a commit that referenced this pull request Sep 19, 2025
@HugoRCD @benjamincanac
fix(Progress): improve status-position when 0 (#4994)
e0891ea 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

@HugoRCD HugoRCD

Labels
v4 #4488
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UProgress 0 is further ahead than 1
2 participants
@HugoRCD @benjamincanac