-
Notifications
You must be signed in to change notification settings - Fork 909
feat(ChatMessage/ChatMessages): add message generics #5259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4
Are you sure you want to change the base?
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to look more closely but I'm not sure the generic will work this way π€ @sandros94 do you have an opinion on this?
Hi @benjamincanac, thanks for the response. I tested it, and it seems to work. I only have some doubts about the implementation I did. I could have probably used the |
Somehow I've missed this notification.
@zAlweNy26 I will leave a couple of reviews with what should be the required changes (tho I'm on mobile, thus I cannot test them directly) |
4f3231c
to
68029e1
Compare
@benjamincanac @sandros94 should I open a PR also in the chat template to fix the error? Or this PR should be retro-compatible? |
Also I noticed a missing prop in the |
7abafbb
to
03f44b2
Compare
π Linked issue
β Type of change
π Description
With this PR, I wanted to add generics in both
ChatMessage
andChatMessages
so that the correct type can be inferred inside slots (like the metadata of every message)π Checklist