This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
fix!: enabled SSR by default and opt-out experimental state #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #185, Close #189
The problem of #185 is caused by the check ignores the check for
ssr: false
and will also disable the server for client build.So I guess maybe we could take the chance to respect the
ssr: false
option in the top-level nuxt config. Giving the SSR has been improved quite a lot since the previous releases, plus this package itself is marked experimental anyway. I'd feel the SSR support is kinda good enough to not be the "experimental-in-experimental" thing. Which this change, this PR makes the behavior less confusing and a bit more robust.