feat: refresh once on navigation & es build #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add global window detection chore: update deps
chore: update example deps
…uxt#320) chore: add es build chore: global window detection chore: small refactor improvements
manniL
reviewed
Feb 20, 2019
chore: reorder package json keys
manniL
reviewed
Feb 22, 2019
pimlie
commented
Feb 23, 2019
feat: provide hasMetaInfo export for other libraries to check if metaInfo has been defined chore: deprecate _hasMetaInfo
This reverts commit 95c3b7d.
|
This is ready for review again. Please merge when ok so I can start working on optimizing getMetaInfo and e2e tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some more optimisation and refactoring.
The
refreshOnceOnNavigationoption is a workaround for #320, but if you have a lot of components that set metaInfo it could also be a performance improvement. Maybe we should just make it defaulttrue?