Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple apps on one page #373

Merged
merged 9 commits into from
Jun 6, 2019
Merged

feat: support multiple apps on one page #373

merged 9 commits into from
Jun 6, 2019

Conversation

pimlie
Copy link
Collaborator

@pimlie pimlie commented Jun 1, 2019

Resolves: #372

Problems with this implementation:

  • have no good solution found yet for html, head, body attributes
  • although vmid's work across app's, support is only partial
    • the value of the last refreshed app is used
    • given app1 and app2 where app2 removes its value for vmid1, then there is no way to retrieve app1's value for vmid1 which means the element is removed

The new multi app example renders as follows:
image

@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #373 into master will decrease coverage by 0.97%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage     100%   99.02%   -0.98%     
==========================================
  Files          30       30              
  Lines         398      409      +11     
  Branches      112      115       +3     
==========================================
+ Hits          398      405       +7     
- Misses          0        4       +4
Impacted Files Coverage Δ
src/server/generators/tag.js 100% <ø> (ø) ⬆️
src/client/updaters/tag.js 100% <100%> (ø) ⬆️
src/client/updateClientMetaInfo.js 92.85% <100%> (-7.15%) ⬇️
src/server/generators/title.js 100% <100%> (ø) ⬆️
src/client/$meta.js 100% <100%> (ø) ⬆️
src/server/generateServerInjector.js 100% <100%> (ø) ⬆️
src/client/refresh.js 100% <100%> (ø) ⬆️
src/shared/constants.js 100% <100%> (ø) ⬆️
src/server/inject.js 100% <100%> (ø) ⬆️
src/server/$meta.js 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c6ad9...f42df23. Read the comment docs.

@pimlie pimlie changed the title WIP feat: support multiple apps on one page feat: support multiple apps on one page Jun 1, 2019
it has no use on the client as we use document.title there. Which also means the appId listed would be wrong once the title is updated by another app then the ssr app
@pimlie pimlie requested review from aldarund, atinux, manniL and pi0 June 1, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple vue app's on one page (i.e. vuetify 2.0 compatiblity)
2 participants