Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): missing type for json property #439

Merged
merged 1 commit into from
Aug 27, 2019
Merged

fix(types): missing type for json property #439

merged 1 commit into from
Aug 27, 2019

Conversation

hudrazine
Copy link
Contributor

@hudrazine hudrazine commented Aug 23, 2019 •
edited
Loading

The new feature added in #415 does not have a json property type definition, so TypeScript compilation fails. This PR adds new interfaces and types.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #439   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...f9bda98. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #439   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...f9bda98. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #439   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...f9bda98. Read the comment docs.

@pimlie pimlie requested a review from kevinmarrec August 23, 2019 15:18
@pimlie pimlie merged commit 96a14f7 into nuxt:master Aug 27, 2019
@hudrazine hudrazine deleted the patch-1 branch August 28, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmarrec kevinmarrec kevinmarrec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hudrazine @kevinmarrec @pimlie