Skip to content

fix(completions): detect object prop type #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix(completions): detect object prop type #51

merged 1 commit into from
Apr 14, 2025
+2 −0

Conversation

adamdehaven
Copy link
Contributor

Some object type props are defined as Record<** e.g. Record<string, any>

Update the logic to not automatically assume they are a string if they contain string in the prop type.

@adamdehaven
Copy link
Contributor Author

@farnabaz small tweak to the prop type object parsing ☘️

farnabaz
farnabaz approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@farnabaz farnabaz merged commit 2b19a3d into nuxtlabs:main Apr 14, 2025
@adamdehaven adamdehaven deleted the fix/object-prop-type-parsing branch April 14, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdehaven @farnabaz