cunumeric/module: implement numpy.meshgrid
#587
Conversation
This commit implements the function `numpy.meshgrid`.
rohany
added
the
category:new-feature
|
|
||
| if not sparse: | ||
| # Return the full N-D matrix (not only the 1-D vector). | ||
| output = np.broadcast_arrays(*output, subok=True) |
There was a problem hiding this comment.
@magnatelee is there a reason why we haven't implemented broadcast, broadcast_to and broadcast_arrays? If not, I can add them relatively easily as part of this PR.
There was a problem hiding this comment.
This is ongoing work #458
There was a problem hiding this comment.
sweet, i'll just wait for that.
|
|
||
| if indexing == "xy" and ndim > 1: | ||
| # Switch first and second axis. | ||
| output[0].shape = (1, -1) + s0[2:] |
There was a problem hiding this comment.
This implementation from numpy muddles around with the shape parameter of the array. Is there something equivalent that I can do that works on both eager and deferred arrays? I'm not sure the right API call to make.
|
@rohany can you sign off this pull request? you can force push changes if you need to. |
|
Yes, I will when the PR is ready (it's quite far from that right now). |
This commit implements the function
numpy.meshgrid.