Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Add suggested fixes for known build errors #599

Open
wants to merge 1 commit into
base: branch-24.03
Choose a base branch
from
Open

DRAFT: Add suggested fixes for known build errors #599

wants to merge 1 commit into from

Conversation

jjwilke
Copy link
Contributor

@jjwilke jjwilke commented Sep 21, 2022

No description provided.

@jjwilke jjwilke added the category:improvement PR introduces an improvement and will be classified as such in release notes label Sep 21, 2022
@jjwilke jjwilke requested a review from bryevdv September 22, 2022 01:01
@jjwilke jjwilke changed the title Add suggested fixes for known build errors DRAFT: Add suggested fixes for known build errors Sep 22, 2022
@jjwilke
Copy link
Contributor Author

jjwilke commented Sep 22, 2022

This needs to both capture output and continue to pipe output to the terminal. I don't recall an easy way to do this with Python.

bryevdv
bryevdv previously approved these changes Sep 22, 2022
View reviewed changes
@manopapad manopapad changed the base branch from branch-22.10 to branch-22.12 September 30, 2022 21:57
@marcinz marcinz changed the base branch from branch-22.12 to branch-23.03 January 26, 2023 00:59
@marcinz marcinz dismissed bryevdv’s stale review January 26, 2023 00:59

The base branch was changed.

@marcinz marcinz changed the base branch from branch-23.03 to branch-23.05 March 6, 2023 20:46
@marcinz marcinz changed the base branch from branch-23.05 to branch-23.07 May 18, 2023 20:29
@marcinz marcinz changed the base branch from branch-23.07 to branch-23.09 July 18, 2023 15:43
@marcinz marcinz changed the base branch from branch-23.09 to branch-23.11 September 26, 2023 00:37
@marcinz marcinz changed the base branch from branch-23.11 to branch-24.01 November 9, 2023 17:14
@marcinz marcinz changed the base branch from branch-24.01 to branch-24.03 February 22, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category:improvement PR introduces an improvement and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjwilke @bryevdv