Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cunumeric: implement np.diff #636

Merged
merged 8 commits into from
Feb 13, 2024
Merged

cunumeric: implement np.diff #636

merged 8 commits into from
Feb 13, 2024

Conversation

rohany
Copy link
Member

@rohany rohany commented Sep 30, 2022

This commit implements some necessary cases of np.diff.

Signed-off-by: Rohan Yadav rohany@alumni.cmu.edu

@rohany rohany requested a review from magnatelee September 30, 2022 17:55
@rohany rohany added the category:new-feature PR introduces a new feature and will be classified as such in release notes label Sep 30, 2022
@rohany rohany requested a review from manopapad October 13, 2022 00:50
@marcinz marcinz changed the base branch from branch-22.12 to branch-23.03 January 26, 2023 00:59
@marcinz marcinz changed the base branch from branch-23.03 to branch-23.05 March 6, 2023 20:46
@marcinz marcinz changed the base branch from branch-23.05 to branch-23.07 May 18, 2023 20:29
@marcinz marcinz changed the base branch from branch-23.07 to branch-23.09 July 18, 2023 15:43
@marcinz marcinz changed the base branch from branch-23.09 to branch-23.11 September 26, 2023 00:37
@marcinz marcinz changed the base branch from branch-23.11 to branch-24.01 November 9, 2023 17:14
@manopapad manopapad mentioned this pull request Jan 25, 2024
Open
22 tasks
bryevdv
bryevdv requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good just a few comments

@rohany
cunumeric: implement np.diff
91ea8d9 
This commit implements some necessary cases of `np.diff`.

Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rohany
Copy link
Member Author

rohany commented Feb 12, 2024

Updated, @bryevdv PTAL

@bryevdv
Copy link
Contributor

bryevdv commented Feb 12, 2024

One linter error @rohany

cunumeric/module.py:6374:10: F821 undefined name 'not_equal'

@rohany
Copy link
Member Author

rohany commented Feb 12, 2024

woops, fixed the missing import

@bryevdv
Copy link
Contributor

bryevdv commented Feb 12, 2024

/ok to test

manopapad
manopapad reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some nits from me too

@rohany
Copy link
Member Author

rohany commented Feb 13, 2024

Updated, ptal.

@bryevdv
Copy link
Contributor

bryevdv commented Feb 13, 2024

/ok to test

@rohany
Copy link
Member Author

rohany commented Feb 13, 2024 •
edited
Loading

@bryevdv can you accept / merge it?

@rohany rohany merged commit fbdfe89 into nv-legate:branch-24.01 Feb 13, 2024
2 checks passed
manopapad pushed a commit that referenced this pull request Feb 18, 2025
@bryevdv
Recent ports from public repo (#146)
30fd2c0 
* add np.digitize (ref: #1117)

* add np.diff (ref: #636)

* add np.load (ref: #1126)

* add cov (ref: #1129)

* add average (ref: #1124)

* add logical reductions (ref: #1123)

* fix docstring syntax

* review comments

* fix import

* fix error from update

* fix copy pasta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manopapad manopapad manopapad approved these changes

@bryevdv bryevdv bryevdv approved these changes

@magnatelee magnatelee Awaiting requested review from magnatelee

Assignees
No one assigned
Labels
category:new-feature PR introduces a new feature and will be classified as such in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohany @bryevdv @manopapad