Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass cmake executable to scikit-build #908

Open
wants to merge 1 commit into
base: branch-24.03
Choose a base branch
from
Open

Pass cmake executable to scikit-build #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,13 @@ def install(
if legion_dir is not None and legion_src_dir is not None:
sys.exit("Cannot specify both --legion-dir and --legion-src-dir")

join = os.path.join
exists = os.path.exists
dirname = os.path.dirname
realpath = os.path.realpath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with

from  os.path import dirname, exists, join, realpath

at the top? Then several places can be shortened


cmake_exe = realpath(cmake_exe)

print(f"Verbose build is {'on' if verbose else 'off'}")
if verbose:
print(f"networks: {networks}")
Expand Down Expand Up @@ -353,11 +360,6 @@ def install(
print(f"legion_branch: {legion_branch}")
print(f"unknown: {unknown}")

join = os.path.join
exists = os.path.exists
dirname = os.path.dirname
realpath = os.path.realpath

legate_core_dir = dirname(realpath(__file__))

pyversion, pylib_name = find_active_python_version_and_path()
Expand Down Expand Up @@ -470,6 +472,8 @@ def validate_path(path):
if not build_isolation:
pip_install_cmd += ["--no-build-isolation"]

pip_install_cmd += [f"--global-option=--cmake-executable={cmake_exe}"]

if editable:
cmd_env.update({"SETUPTOOLS_ENABLE_FEATURES": "legacy-editable"})
cmake_flags += ["-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON"]
Expand Down
Loading