Fix EdgeHolder from incorrectly reporting an active connection #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts check_active_connection from mistakenly returning true for a holder where init_owned_edge has been called but neither the init_connected_edge method or the add_connector method have not been called
mdemoret-nv
approved these changes
Sep 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #402 +/- ##
================================================
+ Coverage 73.59% 73.62% +0.03%
================================================
Files 385 385
Lines 13614 13613 -1
Branches 1028 1027 -1
================================================
+ Hits 10019 10023 +4
+ Misses 3595 3590 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/merge |
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Aug 2, 2024
… raise an exception rather than segfaulting (#1829) * MRC PR nv-morpheus/MRC#402 fixed this issue, this PR adds some unittests to ensure this. * Update `Pipeline.build_and_start` to re-raise any exceptions raised during build, this prevents `Pipeline.join` from being called which avoids a failed assert in `join` since the expected future was not created. Closes #953 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check_active_connectionfrom mistakenly returning true for a holder whereinit_owned_edgehas been called but neither theinit_connected_edge methodor theadd_connectormethod have not been called.Relates to issue #360
Checklist