Update to RAPIDS 24.10 #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwharris
added
non-breaking
Comment on lines
-51
to
-57
| # gflags | ||
| # ====== | ||
| rapids_find_package(gflags REQUIRED | ||
| GLOBAL_TARGETS gflags | ||
| BUILD_EXPORT_SET ${PROJECT_NAME}-exports | ||
| INSTALL_EXPORT_SET ${PROJECT_NAME}-exports | ||
| ) |
There was a problem hiding this comment.
Why are we removing gflags, aren't we using it?
Comment on lines
31
to
+40
| template <typename C> | ||
| class KeyIterator : public std::iterator<std::bidirectional_iterator_tag, | ||
| typename C::key_type, | ||
| typename C::difference_type, | ||
| typename C::pointer, | ||
| typename C::reference> | ||
| class KeyIterator | ||
| { | ||
| public: | ||
| using iterator_category = std::bidirectional_iterator_tag; | ||
| using value_type = C::key_type; | ||
| using difference_type = C::difference_type; | ||
| using pointer = C::pointer; | ||
| using reference = C::reference; | ||
|
|
There was a problem hiding this comment.
Is this change unrelated to the upgrade?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #494 +/- ##
=================================================
- Coverage 74.07% 52.99% -21.08%
=================================================
Files 403 367 -36
Lines 14401 11934 -2467
Branches 1132 1045 -87
=================================================
- Hits 10668 6325 -4343
- Misses 3733 5609 +1876
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 186 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #478
Requires nv-morpheus/utilities#75
Checklist