Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: dfp-models in training-tuning-scripts does not have an environment.yml or requirements.txt #1226

Closed
2 tasks done
nyck33 opened this issue Sep 28, 2023 · 1 comment · Fixed by #1256
Closed
2 tasks done
Assignees
Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team Needs Triage Need team to review and classify

Comments

@nyck33
Copy link

nyck33 commented Sep 28, 2023

How would you describe the priority of this documentation request

medium

Describe the future/missing documentation

https://github.com/nv-morpheus/Morpheus/tree/branch-23.11/models/training-tuning-scripts/dfp-models

The other folders like fraud-detection-models does have one as do the other folders

And I look at the first cell:

import os
import glob

import dill
import matplotlib.pyplot as plt
import numpy as np
import pandas as pd
from sklearn.metrics import confusion_matrix
from sklearn.metrics import f1_score
import torch

from morpheus.models.dfencoder import AutoEncoder
from morpheus.utils.seed import manual_seed

I have the dev container launched in VSCode and tried to run that first cell with the default morpheus environnment that is activated but of course I frist get module dill not found. Then doing conda list I don't see torch nor sklearn.

Then looking down further in that hammah-20211017.ipynb , I see a cell

# uncomment to train on other "role-g" instead of "user123"

# TRAINING_DATA_PATH = "../datasets/training-data/hammah-role-g-training-data.csv"
# VAL_DATA_PATH = "../datasets/validation-data/hammah-role-g-validation-data.csv"
# OUTPUT_MODEL_NAME = "hammah-role-g-20211017.pkl

I've run the script that downloads all the models and examples but don't see any role-g files at all so please advise.

Where have you looked?

See above.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@nyck33 nyck33 added the doc Improvements or additions to documentation label Sep 28, 2023
@jarmak-nv jarmak-nv added Needs Triage Need team to review and classify external This issue was filed by someone outside of the Morpheus team labels Sep 28, 2023
@jarmak-nv
Copy link
Contributor

Hi @nyck33!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

@jarmak-nv jarmak-nv moved this from Todo to In Progress in Morpheus Boards Oct 10, 2023
@efajardo-nv efajardo-nv self-assigned this Oct 10, 2023
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Oct 12, 2023
rapids-bot bot pushed a commit that referenced this issue Oct 13, 2023
- Replace `requirements.txt`files (pip) with `requirements.yml` (conda environment).
- Update dependency versions.

Closes #1226
Closes #1227

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1256
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team Needs Triage Need team to review and classify
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants