Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Install target installs headers into /usr/local/include rather than the conda env #1776

Closed
dagardner-nv opened this issue Jun 28, 2024 · 2 comments · Fixed by #1815
Closed

[BUG]: Install target installs headers into /usr/local/include rather than the conda env #1776

dagardner-nv opened this issue Jun 28, 2024 · 2 comments · Fixed by #1815
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.06

Which installation method(s) does this occur on?

Docker

Describe the bug.

This happens in the dev container, not sure about other envs.

Minimum reproducible example

docker/run_container_dev.sh
CMAKE_CONFIGURE_EXTRA_ARGS="-DMORPHEUS_PYTHON_INPLACE_BUILD=OFF" ./scripts/compile.sh --target install


### Relevant log output

<details><summary>Click here to see error details</summary><pre>

 [Paste the error here, it will be hidden by default]

</pre></details>


### Full env printout

<details><summary>Click here to see environment details</summary><pre>

 [Paste the results of print_env.sh here, it will be hidden by default]

</pre></details>


### Other/Misc.

_No response_

### Code of Conduct

- [X] I agree to follow Morpheus' Code of Conduct
- [X] I have searched the [open bugs](https://github.com/nv-morpheus/Morpheus/issues?q=is%3Aopen+is%3Aissue+label%3Abug) and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jun 28, 2024
@mdemoret-nv
Copy link
Contributor

Are you recommending that we install to /usr/local/include or that it is an error that we install there?

@dagardner-nv
Copy link
Contributor Author

It currently installs headers into /usr/local/include when it should be installing into the conda env.

@dagardner-nv dagardner-nv self-assigned this Jul 15, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Jul 15, 2024
This was referenced Jul 15, 2024
Merged
Merged
@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Jul 15, 2024
@dagardner-nv dagardner-nv mentioned this issue Jul 16, 2024
Merged
3 tasks
rapids-bot bot pushed a commit to nv-morpheus/utilities that referenced this issue Jul 16, 2024
@dagardner-nv
Move the logic inferring the value of CMAKE_INSTALL_PREFIX to it's …
fb2c950 
…own function (#74)

* The `morpheus_utils_initialize_package_manager` needs to be called prior to calling `project`, however the `CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT` isn't defined until after `project` has been called.
* Moves `CMAKE_INSTALL_PREFIX` logic to a new function named `morpheus_utils_initialize_install_prefix`
* This change is needed for nv-morpheus/Morpheus#1776

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #74
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this issue Jul 24, 2024
@dagardner-nv
Ensure proper initialization of CMAKE_INSTALL_PREFIX if needed (#485)
bceb7ef 
* Invoke `morpheus_utils_initialize_install_prefix` function after calling `project`
* Related to nv-morpheus/Morpheus#1776

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #485
@rapids-bot rapids-bot bot closed this as completed in 134cee7 Jul 24, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure proper initialization of CMAKE_INSTALL_PREFIX if needed dagardner-nv/Morpheus
2 participants
@mdemoret-nv @dagardner-nv