Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Create an end-to-end integration test for Kafka #258

Closed
dagardner-nv opened this issue Jul 1, 2022 · 1 comment · Fixed by #308
Closed

[FEA] Create an end-to-end integration test for Kafka #258

dagardner-nv opened this issue Jul 1, 2022 · 1 comment · Fixed by #308
Assignees
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We currently don't have tests for the Kafka source and the Kafka sink.

Describe the solution you'd like
An end to end validation test that is able to spin up docker containers for Kafka in a similar manner to the way the validation tests spin up a container for Triton.

Ideally it would be good to be able to run these tests as a part of CI.
If we had a Kafka cluster setup for the purposes of CI, tests could theoretically create unique topic names for the purposes of testing.

@dagardner-nv dagardner-nv added feature request New feature or request Needs Triage Need team to review and classify labels Jul 1, 2022
@dagardner-nv
Copy link
Contributor Author

Talking with @ajschmidt8 this should be possible with a sidecar container.
Currently this only works with scripted Jenkins pipelines (we have a declarative pipeline), but would be supported by github actions when we move off of Jenkins.

So once the validation test is complete, we could either reformat the Jenkinsfile as a scripted pipeline or use github actions if they are available.

@dagardner-nv dagardner-nv self-assigned this Jul 19, 2022
@dagardner-nv dagardner-nv removed the Needs Triage Need team to review and classify label Jul 19, 2022
@jarmak-nv jarmak-nv moved this to In Progress in Morpheus Boards Aug 8, 2022
@jarmak-nv jarmak-nv moved this from In Progress to Review in Morpheus Boards Aug 10, 2022
@ghost ghost closed this as completed in #308 Sep 7, 2022
@ghost ghost closed this as completed in 5c92142 Sep 7, 2022
Repository owner moved this from Review to Done in Morpheus Boards Sep 7, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants