Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Create Kafka Testing Procedure #265

Closed
mdemoret-nv opened this issue Jul 5, 2022 · 0 comments · Fixed by #290
Closed

[FEA] Create Kafka Testing Procedure #265

mdemoret-nv opened this issue Jul 5, 2022 · 0 comments · Fixed by #290
Assignees
@dagardner-nv
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
During the release process, several Kafka issues inevitably come up. This is mostly due to the difficulty testing Kafka in any automated way. In CI, options for creating additional services is limited and mocking Kafka would be very difficult. The result is most of our unit tests only read/write to files leaving pipelines that use Kafka untested.

Describe the solution you'd like
Ideally, we would integrate Kafka into end-to-end tests that can be run by CI (Tracking issue #258). Until that issue is completed, we will need to manually test kafka workflows. A rough outline of how this would be completed:

  1. Every 2 weeks, a rotating person will download the latest development branch
  2. Create a local Kafka cluster
  3. Run all supported workflows using Kafka
  4. Create any issues for bugs that are discovered.
  5. Update any out of date documentation

Describe alternatives you've considered
See issue #258

Additional context
Documentation for the above steps will need to be created as part of this issue.
@mdemoret-nv mdemoret-nv added feature request New feature or request Priority 0 labels Jul 5, 2022
@dagardner-nv dagardner-nv self-assigned this Jul 19, 2022
@dagardner-nv dagardner-nv mentioned this issue Jul 19, 2022
Merged
@jarmak-nv jarmak-nv moved this to In Progress in Morpheus Boards Aug 8, 2022
@ghost ghost closed this as completed in #290 Aug 8, 2022
ghost pushed a commit that referenced this issue Aug 8, 2022
@dagardner-nv
Manual testing of Morpheus with Kafka & Validation improvements (#290)
bb200ab 
* instructions for manually testing of Morpheus using Kafka. Adds a Kafka version for each of the four validation scripts in `scripts/validation`
* csv & json serializers now support an `include_index_col` flag to control exporting the Dataframe's index column. Note due to a limitation of cudf & pandas this has no impact on JSON:
  + pandas-dev/pandas#37600 
  + rapidsai/cudf#11317
* `morpheus.utils.logging` renamed to `morpheus.utils.logger` so that other modules in `morpheus.utils` can import the standard lib logging module.
* Comparison logic in the `ValidationStage` has been moved to it's own module `morpheus.utils.compare_df` so that the functionality can be used outside of the stage.


fixes #265

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Pete MacKinnon (https://github.com/pdmack)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #290
Repository owner moved this from In Progress to Done in Morpheus Boards Aug 8, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manual testing of Morpheus with Kafka & Validation improvements dagardner-nv/Morpheus
2 participants
@mdemoret-nv @dagardner-nv