Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Publish a Morpheus models container #552

Closed
2 tasks done
dagardner-nv opened this issue Dec 14, 2022 · 5 comments · Fixed by #1804
Closed
2 tasks done

[FEA]: Publish a Morpheus models container #552

dagardner-nv opened this issue Dec 14, 2022 · 5 comments · Fixed by #1804
Assignees
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

We advertise in our documentation that this is the easiest way to start using Morpheus and the pre-trained modules is to use one of our pre-built Docker containers on NGC. However this introduces a few difficulties :

  1. Our containers are large because they include the models
  2. The models are inside the container, requiring the user to launch triton from inside the container, which means they need to mount the docker socket file
  3. The docker command isn't in the container requiring the user to run the docker/install_docker.sh script

Describe your ideal solution

Publish a separate models container that layers on top of Triton

Describe any alternatives you have considered

Install docker in the default container image

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Dec 14, 2022
@pdmack
Copy link
Contributor

pdmack commented Dec 15, 2022

The models are inside the container, requiring the user to launch triton from inside the container, which means they need to mount the docker socket file
The docker command isn't in the container requiring the user to run the docker/install_docker.sh script

The k8s instructions have the user copy out the models, configs, datasets to a host path that can be shared amongst the containers.

@dagardner-nv
Copy link
Contributor Author

@pdmack does that require access to the kubectl command, and thus require running in K8? Is there an equivalent for users running docker locally?

@pdmack
Copy link
Contributor

pdmack commented Dec 15, 2022

A user could also use the docker cp ... command to move the models out of the container to a host path.

@dagardner-nv
Copy link
Contributor Author

That would be a viable alternative then.

@dagardner-nv
Copy link
Contributor Author

Part of this would be to revert and adjust the changes in #1507

@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Jul 8, 2024
@rapids-bot rapids-bot bot closed this as completed in 79ed546 Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants