Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morpheus changes related to utility consolidation #531

Merged

Conversation

drobison00
Copy link
Contributor

@drobison00 drobison00 commented Dec 8, 2022

Depends on: https://github.com/nv-morpheus/utilities/pull/1/files#diff-9a3c07061febeba4d3e5191e87706e262644abf8514317eeb084e67137e7c807

This PR is branched from the base Morpheus conversion to MRC (#530). It may make sense to go in as a monolithic patch, or piecemeal.

Shifts to using a shared utilities submodule for shared cmake, scripts, utilities, etc.. This shared repo provides a number of new morpheus_utils_xxx cmake macros/functions that are now used throughout the configuration process.

Closes #87

@drobison00 drobison00 requested review from a team as code owners December 8, 2022 20:06
.gitmodules Outdated Show resolved Hide resolved
@drobison00 drobison00 self-assigned this Jan 12, 2023
@drobison00 drobison00 added enhancement Additional functionality added to an existing feature non-breaking Non-breaking change 3 - Ready for Review improvement Improvement to existing functionality feature request New feature or request and removed enhancement Additional functionality added to an existing feature feature request New feature or request labels Jan 17, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just a couple of comments.

.gitmodules Outdated Show resolved Hide resolved
ci/scripts/github/common.sh Show resolved Hide resolved
setup.py Show resolved Hide resolved
@drobison00
Copy link
Contributor Author

/merge

@ghost ghost merged commit cdbe4ce into nv-morpheus:branch-23.01 Jan 24, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Create Utility Repo to Store Common Functionality
3 participants