-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Morpheus changes related to utility consolidation #531
Merged
69 commits merged into
nv-morpheus:branch-23.01
from
drobison00:devin_issue_87_mrc_rebase_branch
Jan 24, 2023
Merged
Morpheus changes related to utility consolidation #531
69 commits merged into
nv-morpheus:branch-23.01
from
drobison00:devin_issue_87_mrc_rebase_branch
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild with morpheus from source
drobison00
commented
Dec 8, 2022
drobison00
added
enhancement
Additional functionality added to an existing feature
non-breaking
Non-breaking change
3 - Ready for Review
improvement
Improvement to existing functionality
feature request
New feature or request
and removed
enhancement
Additional functionality added to an existing feature
feature request
New feature or request
labels
Jan 17, 2023
mdemoret-nv
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Just a couple of comments.
dagardner-nv
approved these changes
Jan 23, 2023
/merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: https://github.com/nv-morpheus/utilities/pull/1/files#diff-9a3c07061febeba4d3e5191e87706e262644abf8514317eeb084e67137e7c807
This PR is branched from the base Morpheus conversion to MRC (#530). It may make sense to go in as a monolithic patch, or piecemeal.
Shifts to using a shared
utilities
submodule for shared cmake, scripts, utilities, etc.. This shared repo provides a number of newmorpheus_utils_xxx
cmake macros/functions that are now used throughout the configuration process.Closes #87