Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Create a base class or mixin for egress and ingress stages #638

Closed
2 tasks done
dagardner-nv opened this issue Jan 26, 2023 · 0 comments · Fixed by #1473
Closed
2 tasks done

[FEA]: Create a base class or mixin for egress and ingress stages #638

dagardner-nv opened this issue Jan 26, 2023 · 0 comments · Fixed by #1473
Assignees
@dagardner-nv
Labels
feature request New feature or request
Milestone
24.03 - MNMG

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Change

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

Currently the only two boundary stages that exist are LinearBoundaryEgressStage and LinearBoundaryIngressStage both inherit from SingleOutputSource with presumably others coming once non-linear pipelines are introduced to Morpheus.

It would be nice to have a common base class or mixin to identify these stages as different from general purpose stages and offer a better type hints for Pipeline.add_segment_edge.

Describe your ideal solution

Common base class

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Jan 26, 2023
@mdemoret-nv mdemoret-nv added this to the 24.03 - MNMG milestone Dec 13, 2023
@dagardner-nv dagardner-nv self-assigned this Jan 17, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Jan 17, 2024
@dagardner-nv dagardner-nv mentioned this issue Jan 17, 2024
Merged
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Jan 17, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 22, 2024
@dagardner-nv
Create a base mixin class for ingress & egress stages (#1473)
1b52ab8 
* Creates a new `BoundaryStageMixin` class 
* Allowing `LinearBoundaryEgressStage` and `LinearBoundaryIngressStage` to share a common class and be distinguished from other stages

Closes #638 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1473
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
24.03 - MNMG
Development

Successfully merging a pull request may close this issue.

Create a base mixin class for ingress & egress stages dagardner-nv/Morpheus
2 participants
@mdemoret-nv @dagardner-nv