Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Unify the Morpheus and MRC Devcontainer #704

Open
Tracked by #701
mdemoret-nv opened this issue Feb 14, 2023 · 1 comment
Open
Tracked by #701

[FEA] Unify the Morpheus and MRC Devcontainer #704

mdemoret-nv opened this issue Feb 14, 2023 · 1 comment
Assignees
@cwharris
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

mdemoret-nv commented Feb 14, 2023 •
edited
Loading

Currently, the MRC and Morpheus devcontainers are similar but work in different ways. They should be unified to offer feature parity and streamline working with both repositories.
@mdemoret-nv mdemoret-nv mentioned this issue Feb 14, 2023
Open
@mdemoret-nv mdemoret-nv changed the title Unify the Morpheus and MRC Devcontainer [FEA] Unify the Morpheus and MRC Devcontainer Feb 14, 2023
@mdemoret-nv mdemoret-nv added the feature request New feature or request label Feb 14, 2023
@jarmak-nv jarmak-nv moved this from Todo to In Progress in Morpheus Boards Apr 11, 2023
@mdemoret-nv mdemoret-nv moved this from In Progress to Todo in Morpheus Boards Aug 21, 2023
@cwharris
Copy link
Contributor

This goes along with the #rapidsai/devcontainers work we've been doing. I think the goal here is to get very similar devcontainers for MRC and Morpheus, but also have a "cyber" repository that will mount in both MRC and Morpheus and build them together. That will make it easier to resolve dependency conflicts when doing upgrades.

This was referenced Sep 4, 2023
Merged
Merged
Merged
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this issue Sep 7, 2023
@cwharris
Updates for MRC/Morpheus to build in the same RAPIDS devcontainer env…
79a27e2 
…ironment (#375)

Adds a new `dependencies.yaml` which is used in RAPIDS devcontainer utils to generate conda env yamls, `project.toml`'s, and `setup.py`s on-the-fly using https://github.com/rapidsai/dependency-file-generator. Eventually we can generate/verify our existing environment files this way, but for now this gets us up and running in a RAPIDS devcontainer.

Also changes `prometheus-cpp::core` to a `PRIVATE`ly linked library, as it's not longer necessary to be `PUBLIC`, and otherwise breaks a combined MRC/Morpheus build.

Also adds a `MRC_PYTHON_INPLACE_BUILD` cmake option, which enables pybind11 modules to be copied back to the source tree.

MRC/Morpheus unified build environment is a WIP, but available here: https://github.com/cwharris/cyber-dev.

Contributes to nv-morpheus/Morpheus#704

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #375
rapids-bot bot pushed a commit to nv-morpheus/utilities that referenced this issue Sep 11, 2023
@cwharris
Fix MatX when building MRC and Morpheus in same environment. (#55)
15894ac 
For unknown reasons, when building MRC and Morpheus within the same conda environment, MatX fails to see some c printf macros. Adding `__STDC_FORMAT_MACROS` fixes the issue, though I'm curious as to why this wasn't a problem before. @mdemoret-nv, is there a better way to fix this?

Contributes to nv-morpheus/Morpheus#704

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #55
rapids-bot bot pushed a commit that referenced this issue Sep 12, 2023
@cwharris
Updates for MRC/Morpheus to build in the same RAPIDS devcontainer env…
6558a71 
…ironment (#1171)

Adds a new `dependencies.yaml` which is used in RAPIDS devcontainer utils to generate conda env yamls, `project.toml`'s, and `setup.py`s on-the-fly using https://github.com/rapidsai/dependency-file-generator. Eventually we can generate/verify our existing environment files this way, but for now this gets us up and running in a RAPIDS devcontainer.

Also fixes an issue where newer versions of Boost provide an overload to http request header `insert` where our existing usage would be ambiguous.

MRC/Morpheus unified build environment is a WIP, but available here: https://github.com/cwharris/cyber-dev.

Depends on nv-morpheus/utilities#55

Contributes to #704

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwharris cwharris

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cwharris @mdemoret-nv @jarmak-nv