-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less intrusive doc builds #1060
Merged
rapids-bot
merged 24 commits into
nv-morpheus:branch-23.11
from
dagardner-nv:david-doc-builds-nvt-mock
Aug 23, 2023
Merged
Less intrusive doc builds #1060
rapids-bot
merged 24 commits into
nv-morpheus:branch-23.11
from
dagardner-nv:david-doc-builds-nvt-mock
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disable the inherited-members option only for this one class
…method to be mocked prior to any merlin or nvtabular modules are imported
…try directly, allowing them to be mocked, remove check of MORPHEUS_IN_SPHINX_BUILD env var
…revent side-effects during documentation builds
…n themselves when unwrapping, causing inspect.unwrap to raise a cycle error
dagardner-nv
added
non-breaking
Non-breaking change
doc
Improvements or additions to documentation
3 - Ready for Review
labels
Jul 17, 2023
…avid-doc-builds-nvt-mock
…avid-doc-builds-nvt-mock
mdemoret-nv
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree with some of these changes. By making it "less intrusive" we have separated the workaround from the source code making it harder to maintain in the future.
…orpheus into david-doc-builds-nvt-mock
mdemoret-nv
approved these changes
Aug 23, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
morpheus/utils/nvt/__init__.py
annotate
hack todecorators.py
fixes #1055
Checklist