-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break circular reference issue causing a memory leak #1115
Merged
rapids-bot
merged 28 commits into
nv-morpheus:branch-23.11
from
dagardner-nv:david-destructors-1114
Aug 30, 2023
Merged
Break circular reference issue causing a memory leak #1115
rapids-bot
merged 28 commits into
nv-morpheus:branch-23.11
from
dagardner-nv:david-destructors-1114
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xplicitly release reference to the executor after join and stop
dagardner-nv
added
bug
Something isn't working
non-breaking
Non-breaking change
3 - Ready for Review
labels
Aug 2, 2023
cwharris
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments
…potentially raising an exception, this prevents an attribute error in the destructor
This reverts commit e949da1.
…RC's PyObjectWrapper
dagardner-nv
removed
the
DO NOT MERGE
PR should not be merged; see PR for details
label
Aug 15, 2023
dagardner-nv
added
the
Merge After Dependencies
PR is completed and reviewed but depends on another PR; do not merge out of order
label
Aug 16, 2023
dagardner-nv
commented
Aug 18, 2023
dagardner-nv
removed
the
Merge After Dependencies
PR is completed and reviewed but depends on another PR; do not merge out of order
label
Aug 18, 2023
mdemoret-nv
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Merge once comments are resolved. I think we can remove some of the GC tests since they can be executed better in MRC
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
morpheus/pipeline/pipeline.py
tests/test_multi_segment.py::test_multi_segment_bad_data_type
due to [BUG]: Pipeline left in an inconsistent state when the init function passed to make_segment throws MRC#360fixes #1114
Checklist